andros/emacs-gpu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

icalendar-tests no longer assumes TZ = wall

Browse source 
Do not assume that the TZ environment variable is either unset or
agrees with /etc/localtime.  I ran into this test bug while
running ‘TZ=America/Chicago make check’ on a platform where
/etc/localtime was America/Los_Angeles.
* test/lisp/calendar/icalendar-tests.el:
(icalendar-tests--decode-isodatetime): Don’t use
set-time-zone-rule, whose doc string says “Instead of calling this
function, you typically want something else” for a reason.
Instead, pass the zone arg to icalendar-test--format.
This commit is contained in:
Paul Eggert 2022-06-15 23:05:22 -05:00
parent 160b22ebf7
commit 16ee227c18
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
test/lisp/calendar/icalendar-tests.el
View file

@ -1639,19 +1639,17 @@ SUMMARY:NNN Wwwwwwww Wwwww - Aaaaaa Pppppppp rrrrrr ddd oo Nnnnnnnn 30
"2004-09-17T03:09:10+0000"))
(let ((orig (icalendar-test--format "20040917T050910")))
(unwind-protect
(progn
(set-time-zone-rule "UTC-02:00")
(should (equal (icalendar-test--format "20040917T050910")
(let ((zone "XXX-02"))
(should (equal (icalendar-test--format "20040917T050910" nil zone)
"2004-09-17T03:09:10+0000"))
(should (equal (icalendar-test--format "20040917T0509")
(should (equal (icalendar-test--format "20040917T0509" nil zone)
"2004-09-17T03:09:00+0000"))
(should (equal (icalendar-test--format "20040917")
(should (equal (icalendar-test--format "20040917" nil zone)
"2004-09-16T22:00:00+0000"))
(should (equal (icalendar-test--format "20040917T050910" 1)
(should (equal (icalendar-test--format "20040917T050910" 1 zone)
"2004-09-18T03:09:10+0000"))
(should (equal (icalendar-test--format "20040917T050910" 30)
(should (equal (icalendar-test--format "20040917T050910" 30 zone)
"2004-10-17T03:09:10+0000")))
(set-time-zone-rule 'wall) ;; (set-time-zone-rule nil) is broken
(should (equal orig (icalendar-test--format "20040917T050910")))))
(should (equal (icalendar-test--format "20040917T050910Z")
"2004-09-17T05:09:10+0000"))