andros/emacs-gpu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Try to speed up extended command shorthand computation

Browse source 
Discussed in Bug#51143.

* lisp/simple.el (execute-extended-command--shorter): Compute a
complete list of `commandp' symbols once.  This significantly speeds
up complicated cases while the slowdown of simple cases is still
accetable.
This commit is contained in:
Michael Heerdegen 2022-09-18 12:26:53 +02:00
parent 90c3a25eb1
commit 93136169cb
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lisp/simple.el
View file

@ -2465,9 +2465,13 @@ Also see `suggest-key-bindings'."
(defun execute-extended-command--shorter (name typed)
(let ((candidates '())
commands
(max (length typed))
(len 1)
binding)
;; Precompute a list of commands once to avoid repeated `commandp' testing
;; of symbols in the `completion-try-completion' call inside the loop below
(mapatoms (lambda (s) (when (commandp s) (push s commands))))
(while (and (not binding)
(progn
(unless candidates
@ -2480,8 +2484,8 @@ Also see `suggest-key-bindings'."
(input-pending-p) ;Dummy call to trigger input-processing, bug#23002.
(let ((candidate (pop candidates)))
(when (equal name
(car-safe (completion-try-completion
candidate obarray 'commandp len)))
(car-safe (completion-try-completion
candidate commands nil len)))
(setq binding candidate))))
binding))