andros/standard-notes-to-evernote-or-joplin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improvements on importer and small bug fixes #4

Closed
ArneTR wants to merge 1 commits from master into master
pull from: master
merge into: :master
Conversation 7 Commits 1 Files Changed 1
+38 -30
ArneTR commented 2020-06-02 17:43:55 +02:00 (Migrated from github.com)
Copy Link
Copy Source
  • can import tags and can handle empty tags
  • can handle empty title
  • correct created_at and updated_at
  • close the root note
- can import tags and can handle empty tags - can handle empty title - correct created_at and updated_at - close the root note
tanrax commented 2020-06-02 18:16:38 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Good job @ArneTR

Good job @ArneTR
tanrax commented 2020-06-02 18:17:49 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Could you remove the annotated code fragments?

Could you remove the annotated code fragments?
ArneTR commented 2020-06-03 07:21:05 +02:00 (Migrated from github.com)
Copy Link
Copy Source

I thougt it would make sense to keep them in.

I originally exported from Google Keep To Standard Notes and got these
escapes.

Also the debugging may help for some ... if you don't want them in your
code feel free to cut them out

Best,

Arne

On Tue, Jun 2, 2020, 18:18 Andros Fenollosa notifications@github.com
wrote:

Could you remove the annotated code fragments?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tanrax/standard-notes-to-evernote-or-joplin/pull/4#issuecomment-637659412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB5GL6PUB3UDUBJGENLP5DRUUQ3XANCNFSM4NQ3AS3Q
.

I thougt it would make sense to keep them in. I originally exported from Google Keep To Standard Notes and got these escapes. Also the debugging may help for some ... if you don't want them in your code feel free to cut them out Best, Arne On Tue, Jun 2, 2020, 18:18 Andros Fenollosa <notifications@github.com> wrote: > Could you remove the annotated code fragments? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/tanrax/standard-notes-to-evernote-or-joplin/pull/4#issuecomment-637659412>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAB5GL6PUB3UDUBJGENLP5DRUUQ3XANCNFSM4NQ3AS3Q> > . >
tanrax commented 2020-06-03 16:58:11 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@ArneTR It is not a good practice to leave commented code as it is not self-explanatory. For this, perhaps, it would be advisable to take it to README.md with some commentary. I would appreciate it if you would apply either of these actions :)

@ArneTR It is not a good practice to leave commented code as it is not self-explanatory. For this, perhaps, it would be advisable to take it to README.md with some commentary. I would appreciate it if you would apply either of these actions :)
tanrax (Migrated from github.com) reviewed 2020-06-03 17:08:20 +02:00
standard-notes-to-enex.py
@@ -47,3 +52,2 @@
text = item['content']['text']
text = text_from_html(title, text)
text = item['content']['text']
tanrax (Migrated from github.com) commented 2020-06-03 17:08:20 +02:00
Copy Link
Copy Source

There's bad indentation.

There's bad indentation.
ArneTR (Migrated from github.com) reviewed 2020-06-04 15:55:24 +02:00
standard-notes-to-enex.py
@@ -47,3 +52,2 @@
text = item['content']['text']
text = text_from_html(title, text)
text = item['content']['text']
ArneTR (Migrated from github.com) commented 2020-06-04 15:55:24 +02:00
Copy Link
Copy Source

unclear what you mean by bad indentation ....? Maybe your editor got it wrong? Looks fine to me ...?

Anyhow, I closed the request and send you an new one.

Please have a look at it.

Also you can accept the pull-request and modify it afterwards if you want to have the code differently in your repo. Just wanted you to get the credit and keep it centralised

unclear what you mean by bad indentation ....? Maybe your editor got it wrong? Looks fine to me ...? Anyhow, I closed the request and send you an new one. Please have a look at it. Also you can accept the pull-request and modify it afterwards if you want to have the code differently in your repo. Just wanted you to get the credit and keep it centralised
ArneTR (Migrated from github.com) reviewed 2020-06-04 16:01:30 +02:00
standard-notes-to-enex.py
@@ -47,3 +52,2 @@
text = item['content']['text']
text = text_from_html(title, text)
text = item['content']['text']
ArneTR (Migrated from github.com) commented 2020-06-04 16:01:30 +02:00
Copy Link
Copy Source

sry, my bad. Saw it was just one space instead of usually 4. fixed

sry, my bad. Saw it was just one space instead of usually 4. fixed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
tanrax
ArneTR
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andros (Andros Fenollosa)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: andros/standard-notes-to-evernote-or-joplin#4