andros/standard-notes-to-evernote-or-joplin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improvements on importer and small bug fixes #4

Closed
ArneTR wants to merge 1 commits from master into master
pull from: master
merge into: :master
Conversation 7 Commits 1 Files Changed 1
+2 -5
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
standard-notes-to-enex.py
+2 -5
View File
@@ -24,7 +24,6 @@ final_file = '''
'''
tag_notes_links = {}
# first we build the tag hash
for key, item in enumerate(data['items']):
if item['content_type'] == 'Tag':
for inner_key, reference in enumerate(item['content']['references']):
@@ -44,18 +43,16 @@ counter = 0
for key, item in enumerate(data['items']):
if item['content_type'] == 'Note':
# if 'title' in item['content'] and 'text' in item['content']: # tís this if really needed?
if 'title' in item['content']:
title = item['content']['title']
title = html.escape(title)
# title = re.sub(r'\\([^\w])', r'\1', title) # if you have mal-imported notes from earliner in SN, then this de-escaping may help you
title = re.sub(r'\\([^\w])', r'\1', title) # if you have mal-imported notes from earliner in SN, then this de-escaping may help you
else:
title = "empty title"
text = item['content']['text']
tanrax commented 2020-06-03 17:08:20 +02:00 (Migrated from github.com)
Review
Copy Link
Copy Source

There's bad indentation.

There's bad indentation.
ArneTR commented 2020-06-04 15:55:24 +02:00 (Migrated from github.com)
Review
Copy Link
Copy Source

unclear what you mean by bad indentation ....? Maybe your editor got it wrong? Looks fine to me ...?

Anyhow, I closed the request and send you an new one.

Please have a look at it.

Also you can accept the pull-request and modify it afterwards if you want to have the code differently in your repo. Just wanted you to get the credit and keep it centralised

unclear what you mean by bad indentation ....? Maybe your editor got it wrong? Looks fine to me ...? Anyhow, I closed the request and send you an new one. Please have a look at it. Also you can accept the pull-request and modify it afterwards if you want to have the code differently in your repo. Just wanted you to get the credit and keep it centralised
ArneTR commented 2020-06-04 16:01:30 +02:00 (Migrated from github.com)
Review
Copy Link
Copy Source

sry, my bad. Saw it was just one space instead of usually 4. fixed

sry, my bad. Saw it was just one space instead of usually 4. fixed
text = text_from_html(title, text)
#text = re.sub(r'\\([^\w])', r'\1', text) # if you have mal-imported notes from earliner in SN, then this de-escaping may help you
text = re.sub(r'\\([^\w])', r'\1', text) # if you have mal-imported notes from earliner in SN, then this de-escaping may help you
if item['uuid'] not in tag_notes_links:
print(f"Whoops .... {title} had no tag ... if this is expected, then safely ignore ... Setting tag: 'Missing-Standard-Notes-Tag'.")